Skip to content

fix: remove verifier dead code and add skip logic tests#198

Merged
stranske merged 2 commits intomainfrom
fix/verifier-cleanup-dead-code
Dec 26, 2025
Merged

fix: remove verifier dead code and add skip logic tests#198
stranske merged 2 commits intomainfrom
fix/verifier-cleanup-dead-code

Conversation

@stranske
Copy link
Copy Markdown
Owner

@stranske stranske commented Dec 26, 2025 •
edited by agents-workflows-bot bot
Loading

Automated Status Summary

Scope

  • Scope section missing from source issue.

Tasks

  • Tasks section missing from source issue.

Acceptance criteria

  • Acceptance criteria section missing from source issue.

Head SHA: f2d5077
Latest Runs: ❔ in progress — Gate
Required: gate: ❔ in progress

Workflow / Job Result Logs
Agents PR meta manager ❔ in progress View run
CI Autofix Loop ✅ success View run
Copilot code review ❔ in progress View run
Gate ❔ in progress View run
Health 40 Sweep ✅ success View run
Health 44 Gate Branch Protection ❔ in progress View run
Health 45 Agents Guard ✅ success View run
Health 50 Security Scan ❔ in progress View run
Maint 52 Validate Workflows ✅ success View run
PR 11 - Minimal invariant CI ✅ success View run
Selftest CI ❔ in progress View run

@stranske
fix: remove dead code and add skip logic tests
f2d5077 
Address code review feedback from PR #196:

1. Remove formatErrorIssue dead code - function was never exported from
   verifier_issue_formatter.js, so the import was undefined and the
   conditional branch never executed. Simplified to just use fallback.

2. Add test coverage for acceptance criteria skip logic - new tests
   verify verifier skips when no acceptance content exists and runs
   when acceptance is in a linked issue.
Copilot AI review requested due to automatic review settings December 26, 2025 20:22
@stranske stranske temporarily deployed to agent-high-privilege December 26, 2025 20:22 — with GitHub Actions Inactive
@agents-workflows-bot
Copy link
Copy Markdown
Contributor

agents-workflows-bot bot commented Dec 26, 2025

⚠️ Action Required: Unable to determine source issue for PR #198. The PR title, branch name, or body must contain the issue number (e.g. #123, branch: issue-123, or the hidden marker ).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 26, 2025 •
edited
Loading

Automated Status Summary

Head SHA: 28b63fb
Latest Runs: ⏳ pending — Gate
Required contexts: Gate / gate, Health 45 Agents Guard / Enforce agents workflow protections
Required: core tests (3.11): ⏳ pending, core tests (3.12): ⏳ pending, docker smoke: ⏳ pending, gate: ⏳ pending

Workflow / Job Result Logs
(no jobs reported) ⏳ pending —

Coverage Overview

  • Coverage history entries: 1

Coverage Trend

Metric Value
Current 77.97%
Baseline 0.00%
Delta +77.97%
Minimum 70.00%
Status ✅ Pass

Updated automatically; will refresh on subsequent CI/Docker completions.

Keepalive checklist

Scope

  • Scope section missing from source issue.

Tasks

  • Tasks section missing from source issue.

Acceptance criteria

  • Acceptance criteria section missing from source issue.

@stranske stranske temporarily deployed to agent-high-privilege December 26, 2025 20:23 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 26, 2025 •
edited
Loading

🤖 Keepalive Loop Status

PR #198 | Agent: Codex | Iteration 0/5

Current State

Metric Value
Iteration progress [----------] 0/5
Action wait (missing-agent-label)
Gate success
Tasks 0/2 complete
Keepalive ❌ disabled
Autofix ❌ disabled

🔍 Failure Classification

| Error type | infrastructure |
| Error category | resource |
| Suggested recovery | Confirm the referenced resource exists (repo, PR, branch, workflow, or file). |

Copilot AI reviewed Dec 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses code review feedback from closed PR #196 by removing dead code and adding test coverage. The changes focus on cleaning up the verifier workflow's error handling and ensuring the acceptance criteria skip logic is properly tested.

  • Removes unreachable code branch for formatErrorIssue function that was never exported
  • Adds test coverage for acceptance criteria skip logic with two new test cases

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/reusable-agents-verifier.yml Removes dead code import and conditional branch for formatErrorIssue, simplifies error handling to use the working fallback directly
.github/scripts/__tests__/agents-verifier-context.test.js Adds two tests verifying skip behavior when no acceptance criteria exists and run behavior when acceptance criteria exists only in linked issues

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@stranske stranske merged commit c7ae154 into main Dec 26, 2025
36 checks passed
@stranske stranske deleted the fix/verifier-cleanup-dead-code branch December 26, 2025 20:25
@github-actions github-actions bot mentioned this pull request Dec 26, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stranske